Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add tags on Anki cards with a property #147

Closed
Futur3r opened this issue Jan 23, 2023 · 9 comments
Closed

Ability to add tags on Anki cards with a property #147

Futur3r opened this issue Jan 23, 2023 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Futur3r
Copy link

Futur3r commented Jan 23, 2023

Describe the solution you'd like
I saw that tags of Anki cards are added with the hashtag syntax of logseq, but would it be possible to disable that and add tags via the tags:: property of Logseq with the same mechanism of the deck:: property (blocks of a page inherit the page properties) .
The switch could be made as an option in the settings.

Describe how it will help your workflow
When I add Logseq links as hashtags, it's not for Anki and it pollutes my Anki tags.
For flashcards I add simple tags for a whole Logseq Notes, so the mechanism of the deck:: property is better for me.

@Futur3r Futur3r added the enhancement New feature or request label Jan 23, 2023
@debanjandhar12 debanjandhar12 added the good first issue Good for newcomers label Jan 25, 2023
@thiswillbeyourgithub
Copy link

Bumping this because I would really need this :)

@thiswillbeyourgithub
Copy link

thiswillbeyourgithub commented Apr 22, 2023

Also, I noticed that you can specify deck:: some::deck as a property of a parent block (so all the cards created as children of its childrens (!) are in the same deck) but you can't do that with tags:: property.

But you can set the tags in the children directly. I think it would be a great improvement if we could set the tags:: in the parents just like for deck.

My use case is that I'm a medical student with lots of decks and lots of nested cards.

Related to #117 (comment)

@thiswillbeyourgithub
Copy link

thiswillbeyourgithub commented May 10, 2023

Sorry for the multiple message, don't take it as harassment please :) I'm offering a $20 bounty for the tag feature suggested in #117 via your coffee tip if that can help :)

Have a nice day !

@debanjandhar12
Copy link
Owner

No need to apologize. I should be the one apologizing for not replying earlier.

As for #117, I will look into it this weekend.

Also, just to clarify, the FR is for supporting this way of specifying tags for cards, right?:
image

@thiswillbeyourgithub
Copy link

No need to apologize. I should be the one apologizing for not replying earlier.

FOSS is good only when it works for the author's pace :)

Yes, the FR is to have cards be tagged with any tag in the "above" hierarchy. Basically like the decks property but where they are all taken into accounts instead of the "closest property" (as is the case for decks).

debanjandhar12 added a commit that referenced this issue May 12, 2023
debanjandhar12 added a commit that referenced this issue May 13, 2023
@debanjandhar12
Copy link
Owner

Added in v4.6.1

@thiswillbeyourgithub
Copy link

Thanks a lot a lot a lot, it's really great. I do notice however that if I have the following structure :

- # some title
  tags:: psychiatry
    - some other stuff
      tags:: psychiatry::antipsychotics

Then the resulting card will have 2 tags psychiatry psychyatry::antipsychotics instead of just psychiatry::antipsychotics. Given how anki handles the tags I think it would be best to only include the tags that are not already implied as it will otherwise quickly clutter my collection.

What do you think?

@thiswillbeyourgithub
Copy link

Also found a bug: the addon only works with "tags" and not "Tags" even though logseq is case insensitive regarding properties. This is problematic because if you have Tags:: something, and turn it into tags:: something Logseq will ignore the change.

Expected behavior is then to fetch tags properties case insensitively.

@debanjandhar12
Copy link
Owner

debanjandhar12 commented May 16, 2023

Thanks a lot a lot a lot, it's really great. I do notice however that if I have the following structure :

- # some title
  tags:: psychiatry
    - some other stuff
      tags:: psychiatry::antipsychotics

Then the resulting card will have 2 tags psychiatry psychyatry::antipsychotics instead of just psychiatry::antipsychotics. Given how anki handles the tags I think it would be best to only include the tags that are not already implied as it will otherwise quickly clutter my collection.

What do you think?

Sorry, can you create a new issue for it? I will take a look at it sometime around Friday. It should be fairly easy to do with hash maps.

Also found a bug: the addon only works with "tags" and not "Tags" even though logseq is case insensitive regarding properties. This is problematic because if you have Tags:: something, and turn it into tags:: something Logseq will ignore the change.

Expected behavior is then to fetch tags properties case insensitively.

A new issue for this as well would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants