Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add beancount hash tag support #67

Merged
merged 10 commits into from
Nov 1, 2022
Merged

Conversation

p3psi-boo
Copy link
Contributor

支持 Beancount 的 Hashtag,目前仅实现了支付宝以及微信

用法:
在规则添加 tags 字段,多个 tag 之间用 seq(默认为,)进行分隔。

@Triple-Z
Copy link
Member

Good feature :) but I prefer to use the metadata :P

@p3psi-boo
Copy link
Contributor Author

我这边的账单不全是生成的,有时候会自己手动录入一些数据,特别是一段时间的账单,用 pushtagpoptag 比较方便,然后这样子可以和生成的一起查询。

因此如果有类似我这种使用场景的,可以用 tag 来标记。

代码可能不太好,第一次写 Golang,望请多多包涵。

Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Please help fix the test cases.

@p3psi-boo
Copy link
Contributor Author

Fixed

@gaocegege
Copy link
Member

LGTM

/cc @Triple-Z

Let's merge it.

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, please look at the transaction template.

pkg/compiler/beancount/template.go Outdated Show resolved Hide resolved
@p3psi-boo p3psi-boo requested a review from a team as a code owner October 17, 2022 09:24
Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请修复测试。

example/alipay/example-alipay-output.beancount Outdated Show resolved Hide resolved
example/wechat/example-wechat-output.beancount Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- test(wechat): add test for multiple tags

Signed-off-by: Triple-Z <me@triplez.cn>
Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Triple-Z Triple-Z merged commit 59aa3fc into deb-sig:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants