Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wechat): 去掉默认忽略零钱和零钱通互转的逻辑 #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CodeDaraW
Copy link
Member

Description

参考 #106#107 ,解决之前讨论的问题。

Motivation and Context

「零钱通」的英文名参考微信官方翻译 Mini Fund

Dependencies

N/A

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

make test

Is this change properly documented?

Please make sure you've properly documented the changes you're making.

Don't forget to add an entry to the CHANGELOG/README if necessary (new features, breaking changes, relevant internal improvements).

@CodeDaraW CodeDaraW requested review from gaocegege, Triple-Z and a team as code owners February 6, 2025 12:44
@CodeDaraW
Copy link
Member Author

感觉这个算是 Breaking change?
辛苦看看有在 README 中增加说明的必要吗 😆

Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议提供一个样例规则,能够让客户继续将“零钱”和“零钱通”互转的交易忽略掉。

个人觉得也不算很大的 breaking change,配置修改就可以兼容。

@CodeDaraW CodeDaraW force-pushed the feat-wechat-cash-to-cash branch from dc99e05 to 0ff8ef2 Compare February 14, 2025 17:47
@CodeDaraW
Copy link
Member Author

建议提供一个样例规则,能够让客户继续将“零钱”和“零钱通”互转的交易忽略掉。

个人觉得也不算很大的 breaking change,配置修改就可以兼容。

好建议,已经更新在 README 中,辛苦再 review 下。

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants