Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alipay): refine refund and closed transaction handling logic #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Creling
Copy link

@Creling Creling commented Feb 2, 2025

Description

修复了原先逻辑可能遗漏的两类”退款成功“和”交易关闭“交易记录

  • ”退款成功“状态的交易记录的category未必都是“退款”,“退款成功”的饿了么订单记录的category是“餐饮美食”
2024-*****,餐饮美食,饿了么,e50***@alibaba-inc.com,退款-饺子*****,不计收支,27.00,建设银行储蓄卡(5503),退款成功,2024111422001138361434487255_13130601324111427241160943669	,13120600724111419446389943669	,,
  • “交易关闭”状态的交易记录的type未必都是“不计收支”,“交易关闭”的闲鱼卖出记录的type是“收入”
2024-*****,收入,****n,105***@qq.com,logitech *****,收入,150.00,,交易关闭,2024101923001114791428992964	,T200P2331530004732165953	,,

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Creling Creling requested review from gaocegege, Triple-Z and a team as code owners February 2, 2025 07:53
@Triple-Z
Copy link
Member

扩大了“退款成功”和“交易关闭“的忽略账单范围。对于支付宝账单而言,有没有可能误伤一些本该记录的交易?

/cc @gaocegege

@gaocegege
Copy link
Member

整一个 CLI argument flag 来控制呢?

@Creling
Copy link
Author

Creling commented Feb 12, 2025

扩大了“退款成功”和“交易关闭“的忽略账单范围。对于支付宝账单而言,有没有可能误伤一些本该记录的交易?

/cc @gaocegege

我的观点是,状态为“退款成功”和“交易关闭“的交易,本就应该考虑忽略它们,如果可能会误伤一些本该记录的交易。应该对这些交易额外添加豁免。

也就是说,对“退款成功”和“交易关闭“状态的交易的处理应该是一个白名单机制:对一部分不该忽略的交易添加白名单,豁免忽略。而不是黑名单机制:手动提交应该忽略的交易。无论如何,“退款成功”和“交易关闭“状态的交易中,应该忽略的交易占了大多数,而这些应该忽略的交易的特征非常复杂,如果手动添加,非常容易遗漏。

我们目前可能还没有找到,状态为“退款成功”和“交易关闭“,但不应该忽略的交易,如果找到了,把这些交易按照特征添加进白名单并不复杂。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants