Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance documentation #2

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Enhance documentation #2

merged 3 commits into from
Jun 10, 2024

Conversation

ppsimatikas
Copy link
Collaborator

Add a few more steps on the documentation and a nvmrc file to much the node version used in the .github/ci.yml

@ppsimatikas ppsimatikas requested a review from beeman June 7, 2024 13:34
@@ -34,6 +34,13 @@ Copy the `.env.example` file to `.env` and fill in the missing values.
cp .env.example .env
```

Create a `JWT_SECRET` and a `SESSION_SECRET`, using the command below, and update them in `.env` file:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we could add some hard coded ones on the .env.example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good practice to teach people to generate it. If they want to be lazy and insecure they will probably set it to secret or foo anyway 😁

@beeman beeman force-pushed the panos/Documentation branch from 82c9a71 to b8b0a33 Compare June 10, 2024 19:20
@beeman beeman merged commit 924848a into main Jun 10, 2024
6 checks passed
@beeman beeman deleted the panos/Documentation branch June 10, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants