remove image steam listener on dispose #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonttf Could you remove that file? I'd be glad to merge it then. |
|
@jasonttf Can we get this ready to merge? This issue really needs to be addressed. |
|
@theLee3 Let's see, I temporarily replaced the .lock file, I will remove it again after the merge. Also manually resolved a conflict. Will it fly? |
|
@theLee3 If you can confirm that it works, I'll publish it. My first tests show no problems. |
|
Works well, and leak is resolved. Great job. |
|
Published then. Just out of curiosity: how did you see the leak? Direct error in your app or only by using some profiling-analyzing tool to look for it specifically? |
|
BlocObserver error logging showed constant attempted accesses to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.