Ensured that original buffer is initialized in test_decompression #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been prototyping a version of Miri that can execute foreign functions. It found a bug in the test case
test_decompression
.THe buffer
orig
is only partially initializedLater, its contents is compared against another buffer using
assert_eq!
This uses the intrinsic
compare_bytes
, which requires both slices to be fully initialized.Commit b45549d fixes this by zero-initializing the buffer
orig
usingorig.fill(0)
.