Move arrow to Suggests #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the work @thisisnic! |
|
Wow great work !!! Unfortunately, I'm very booked up this month and I'm afraid I won't have enough time to review the PR properly 😞 |
|
@nbc I think we can close this PR now that arrow is back on CRAN ? |
|
Yes @ddotta we can close ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to apache/arrow#39806. Since it's not clear that we'll be able to resolve everything with CRAN before February 9, this PR moves arrow from Imports to Suggests. When submitted to CRAN, this will prevent your checks failing on CRAN due to arrow's potential archival, but if we don’t get removed, or when we do get back on CRAN, you can revert this.
I've tested this locally by uninstalling arrow and running
devtools::check(".", env_vars = c(NOT_CRAN="false")), though if I had more time to look at this, I might have gone through the tests and only skipped the ones which definitely require arrow and not all of them.