-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #89: Style/SCSS review #91
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
@import "../common/variables.scss"; | ||
|
||
/* | ||
Global application wide styles and fonts | ||
*/ | ||
body { | ||
font-family: 'Montserrat', sans-serif; | ||
background-color: $light; | ||
display: block !important; | ||
} | ||
|
||
.column { | ||
margin: 15px 0; | ||
} | ||
|
||
::-webkit-scrollbar { | ||
display: none; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
@font-face { | ||
font-family: 'Montserrat'; | ||
src: url('../fonts/Montserrat-ExtraLight.ttf') format('truetype'); | ||
font-weight: normal; | ||
font-style: normal; | ||
} | ||
|
||
h1, h2, h3 { | ||
color: $primary; | ||
} | ||
|
||
h1 { | ||
font-size: 2rem; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. r/em isn't super required here since it's a packaged electron app, but i'm alright with going with rem going forward in the event we port to web. |
||
|
||
h2 { | ||
font-size: 1.5rem; | ||
} | ||
|
||
h3 { | ||
font-size: 1.2rem; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
$primary: #28bde4; | ||
$light: #c5c5c5; | ||
$dark: #23282b; | ||
$red: #d80000; | ||
$grey: #878787; | ||
$transparentDarkGrey: rgba(100,100,100,0.3); | ||
|
||
$theme-colors: ( | ||
"primary": $primary, | ||
"secondary": $grey, | ||
"light": $light, | ||
); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. theme-colors is an interesting new addition to bootstrap that I haven't played with much. Looks interesting! Though if i'm understanding this correctly we're not actually using this anywhere are we? all the references to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right -- I am not using the map directly, but Bootstrap actually uses the https://github.com/twbs/bootstrap/blob/v4-dev/scss/_alert.scss#L47-L51 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah, interesting, that's pretty cool! in previous experiments of sass-maps, in the case of a whitelabeled/rebranded ui it became kind of a PITA to update say a primary button color, does TWBS 4 have a better way of handling that besides overriding the entire map? Meaning, can we easily override just $theme-colors('primary') in an overrides file or would we have to redefine the entire map again? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can declare your https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss#L74-L84 Basically this is saying "If there is no It's all about that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here is a thread in Bootstrap's repo where the devs/designers go back and forth on this if you're interested: twbs/bootstrap#23260 |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
@import "../common/variables.scss"; | ||
|
||
.btn { | ||
cursor: pointer; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for modularizing these! The intention is to co-locate the styles with the react components in the upcoming refactor, you've just saved me a good bit of work. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
@import "../common/variables.scss"; | ||
|
||
/* | ||
Footer styles | ||
*/ | ||
.footer { | ||
height: 66px; | ||
background-color: $dark; | ||
bottom: 0; | ||
position: fixed; | ||
width: 100%; | ||
} | ||
|
||
.router-status { | ||
line-height: 66px; | ||
color: $white; | ||
float: right; | ||
} | ||
|
||
.router-status-label { | ||
color: $light; | ||
float: right; | ||
padding: 0 10px; | ||
line-height: 66px; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
@import "../common/variables.scss"; | ||
|
||
/* | ||
Header styles | ||
*/ | ||
.navbar { | ||
background-color: $dark; | ||
} | ||
|
||
.ddev-logo { | ||
height: 50px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! i didn't realize v4 finally went stable last month. feels like it's been in beta forever!