-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCSS Review #89
Comments
|
@jdarrohn Could you do a PR with your proposals? Thanks! |
I agree with your points and definitely thank you for pointing out the new $theme-colors maps that TWBS 4 beta utilize, they're pretty handy! As for r/em vs px, as this is a controlled electron app, we'll have control over it and I think keeping with px definitions is preferred for simplicity. As you've got the changes in an active PR, I think we can close this out. Thoughts @rfay / @rickmanelius ? |
reviewed and merged #91 into master, thanks @jdarrohn ! |
What happened (or feature request):
What you expected to happen:
Please note:
The text was updated successfully, but these errors were encountered: