Fix undefined behavior affecting consensus tree building for trees wi…

…th 32N leaves
ddarriba · Jun 28, 2023 · 5f5f03f · 5f5f03f
1 parent 1780193
commit 5f5f03f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/tree/consensus.c b/src/tree/consensus.c
@@ -1109,11 +1109,12 @@ static void reverse_split(pll_split_t split, unsigned int tip_count)
   unsigned int split_len  = tip_count / split_size + (split_offset>0);
   unsigned int i;
 
-  if (!split_offset) split_offset = split_size;
-
   for (i=0; i<split_len; ++i)
     split[i] = ~split[i];
 
+  if (!split_offset) 
+    return;
+
   pll_split_base_t mask = (1u<<split_offset) - 1;
   split[split_len - 1] &= mask;
 }