fix cross compilation #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing build scripts, [cargo sets several environment variables](https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts). Use the cargo-supplied value for `RUSTC`. This _also_ allows `libudev-sys` to be build by [bazel](https://bazel.build) using rules created by `cargo raze`. Signed-off-by: Chris Frantz <cfrantz@google.com>
11 tasks
|
The reason this has worked for many is due to libudev being installed correctly for the host, but if libudev is only available for the target, the old implementation fails. |
Emilgardis
commented
Nov 21, 2023
build.rs
Outdated
Comment on lines
47
to
68
| if !output.status.success() { | ||
| println!( | ||
| "cargo:warning=Failed to compile test program for udev function `{}`", | ||
| function_name | ||
| ); | ||
| println!("cargo:warning=Using command`{:?}`", cmd); | ||
| println!( | ||
| "cargo:warning=stdout={}", | ||
| String::from_utf8_lossy(&output.stdout) | ||
| .trim() | ||
| .replace("\n", "\ncargo:warning=") | ||
| ); | ||
| println!( | ||
| "cargo:warning=stderr={}", | ||
| String::from_utf8_lossy(&output.stderr) | ||
| .trim() | ||
| .replace("\n", "\ncargo:warning=") | ||
| ); | ||
| false | ||
| } else { | ||
| true | ||
| } |
There was a problem hiding this comment.
this might be a bit noisy if the function is not expected to work. would be better if this crate instead of checking if udev_hwdb_new works, include hwdb unconditionally if feature flag hwdb is included, and let the normal rustc invocation fail linking
|
Thanks for this fix, it resolves I believe this can be resolved with an Can be tested with test project: https://github.com/tuna-f1sh/cross-udev-hwdb/tree/main |
|
fixed! @tuna-f1sh |
tuna-f1sh
added a commit
to tuna-f1sh/cyme
that referenced
this pull request
Nov 22, 2023
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cross-rs/cross#1377
This fixes wrong assumptions done in the build script so that the correct link paths, linker and target are used.
includes #11