Drop old squadron rules. #3176
Merged
Drop old squadron rules. #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old mode where squadrons started empty and had no size limit is going away. I bumped the campaign versions for the ones that claimed support and tested a handful. All of Fuzzle's campaigns actually had the wrong version in the yaml. They claim support for this but none that I tested actually fit within the limits (despite having sizes defined). Either it was supposed to be 10.7, or maybe the airports lost some parking.
Codecov Report
@@ Coverage Diff @@
## develop #3176 +/- ##
========================================
Coverage 45.78% 45.78%
========================================
Files 474 474
Lines 25793 25788 -5
Branches 4515 4513 -2
========================================
- Hits 11809 11808 -1
+ Misses 13963 13959 -4
Partials 21 21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new rules (max squadron sizes, start the campaign with full squadrons) appear to be working well, so enabling them by default and dropping the old rules.
I bumped the campaign versions for the ones that claimed support and tested a handful. All of Fuzzle's campaigns actually had the wrong version in the yaml. They claim support for this but none that I tested actually fit within the limits (despite having sizes defined).