Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address issue 3162 by applying threshold to CVN position check #3174

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

zhexu14
Copy link
Collaborator

@zhexu14 zhexu14 commented Sep 23, 2023

This PR addresses #3162 by applying a threshold on the CVN position check. In the save game provided in #3162 , the floating point comparison were failing even though the CVN was in (roughly) the same position.

This PR was tested by:

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #3174 (352d6bf) into develop (2344fc0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3174   +/-   ##
========================================
  Coverage    45.78%   45.78%           
========================================
  Files          474      474           
  Lines        25793    25793           
  Branches      4515     4515           
========================================
  Hits         11809    11809           
  Misses       13963    13963           
  Partials        21       21           
Files Changed Coverage Δ
...siongenerator/aircraft/waypoints/recoverytanker.py 30.00% <0.00%> (ø)

@DanAlbert DanAlbert merged commit 20574e3 into dcs-liberation:develop Oct 1, 2023
7 checks passed
@zhexu14 zhexu14 deleted the issue_3162 branch November 2, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants