Add logging #1212
Merged
Add logging #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bamarni
commented
Apr 17, 2018
bamarni
commented
- Add logrus as a dependency
- Add flags for verbose outputs
pkg/cmd/dcos.go
Outdated
| } | ||
|
|
||
| cmd.PersistentFlags().CountVarP(&verbose, "", "v", "verbose (-v, or -vv)") |
There was a problem hiding this comment.
s/verbose (-v, or -vv)/verbosity (-v or -vv). Also, the current output -v, -- count verbose (-v, or -vv) is not very meaningful (what does -- count means?), is there any way we can customize it?
| revision = "7b2c5ac9fc04fc5efafb60700713d4fa609b777b" | ||
| version = "v0.0.1" | ||
| revision = "a1f051bc3eba734da4772d60e2d677f47cf93ef4" | ||
| version = "v0.0.2" |
There was a problem hiding this comment.
Why are we doing the update in this commit? Is it necessary for logrus?
There was a problem hiding this comment.
With this old cobra version the usage output is a bit worse : spf13/pflag#141
|
Updated it, I agree the usage help output should be improved for this flag. I couldn't find a simple way to customize it yet. We can revisit this later as the flag still behaves as expected and it's only about the help output (which we are probably going to customize anyway). |
armandgrillet
previously approved these changes
Apr 18, 2018
This package will be used for CLI logging. Also update existing dependencies.
A logger is introduced, the -v and -vv global flags can control its level. The -v flag sets the level to info while the -vv flag sets the level to debug.
armandgrillet
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.