Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JSON Schema version and lower cache size. #789

Merged
merged 5 commits into from
Aug 22, 2020

Conversation

jeschkies
Copy link
Contributor

Summary:
This will lower the memory usage by ignoring the JSON schema cache.
Since we are not using any URIs to load the JSON schema it is cached
each time a new.

JIRA issues: D2IQ-68617

Summary:
This will lower the memory usage by ignoring the JSON schema cache.
Since we are not using any URIs to load the JSON schema it is cached
each time a new.

JIRA issues: D2IQ-68617
@jeschkies jeschkies requested a review from pierrebeitz June 24, 2020 14:51
@jeschkies
Copy link
Contributor Author

jeschkies commented Jun 24, 2020

The benchmark uses wrk with the following LUA script

❯ cat render_package.lua
wrk.method = "POST"
wrk.body   = '{"appId": "mom", "options": {}, "packageName": "marathon", "packageVersion": "1.7.188"}'
wrk.headers["Accept"] = "application/vnd.dcos.package.render-response+json;charset=utf-8;version=v1"
wrk.headers["Content-Type"] = "application/vnd.dcos.package.render-request+json;charset=utf-8;version=v1"

and is run via

❯ wrk -s render_package.lua -d 5m -t 10 http://127.0.0.1:7070/package/render

This is a run with this patch
benchmark

compare it to the current master
master

@pierrebeitz
Copy link
Contributor

the python-error is fixed by now. next step is to fix masters CI.

@kaiwalyajoshi kaiwalyajoshi merged commit e49fb1b into master Aug 22, 2020
@janisz janisz deleted the karsten/bump-json-schema branch September 28, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants