Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve optional DICOM SegmentDescription during renumbering #419

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

rogerbramon
Copy link
Contributor

This pull request adds support for handling the optional DICOM SegmentDescription field during segment renumbering. If the source segment includes a SegmentDescription, it will be copied to the renumbered segment.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for dcmjs2 ready!

Name Link
🔨 Latest commit d344d4e
🔍 Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/6787de7a4d80170008168f83
😎 Deploy Preview https://deploy-preview-419--dcmjs2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rogerbramon rogerbramon force-pushed the preserve-segment-description branch from 55ed61d to d344d4e Compare January 15, 2025 16:12
@rogerbramon
Copy link
Contributor Author

@pieper, could you please review this PR and let me know your thoughts?

Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pieper pieper merged commit d6ac162 into dcmjs-org:master Jan 17, 2025
14 checks passed
Copy link

🎉 This PR is included in version 0.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants