-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/wadors seg creation #360
Open
emelalkim
wants to merge
26
commits into
master
Choose a base branch
from
fix/wadorsSegCreation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
9915f84
add _createSegFromJSONObjects method to use DICOMweb JSON Objects to …
emelalkim 0854eba
add build for debugging
emelalkim 348ddd6
fix dcmjs reference
emelalkim eddc951
update builds
emelalkim e2b8c69
update generate segmentation to handle cornerstone metadata objects
emelalkim b198472
update builds
emelalkim bc14414
fix classname
emelalkim 0d9eaee
temporary _meta fill in
emelalkim 94b3808
fix dataset and sourceImageMetadata retrieve
emelalkim 433f221
update builds
emelalkim 63df7b1
update remaining sourceImageMetadata retrievals
emelalkim d29d71c
update builds
emelalkim 98d92d3
remove builds
emelalkim d79fbb1
add builds
emelalkim 32b3b1e
fix metadata retrieval
emelalkim 1694687
update builds
emelalkim 3d4b1fc
fix other modules
emelalkim f90bbfb
update sopcommonmodule retrieval
emelalkim bdd72b5
update builds
emelalkim 9602624
remove unnecessary ImageOrientationPatient manupulation and adds log …
emelalkim ce3e86b
update builds
emelalkim 9145102
remove log
emelalkim 4f843c4
update build
emelalkim cdf7f04
refactor generateSegmentation to remove duplicate code
emelalkim a1ffae5
Merge branch 'master' into fix/wadorsSegCreation
emelalkim 4107308
update builds after rebase
emelalkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,3 @@ node_modules | |
| yarn-error.log | ||
| yarn.lock | ||
| .DS_Store | ||
| build | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intentional? I think we want to keep these build files out of the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's how we tested it without releasing it. I wanted to keep it till we agree that it's ready to merge so that we can test it again