TaskRunnerActor accepts unknown events (ydb-platform#576)

dcherednik · Dec 19, 2023 · 55d122b · 55d122b
1 parent f2ff854
commit 55d122b
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/ydb/library/yql/providers/dq/task_runner_actor/task_runner_actor.cpp b/ydb/library/yql/providers/dq/task_runner_actor/task_runner_actor.cpp
@@ -136,15 +136,23 @@ class TTaskRunnerActor
         }
     }
 
-    STRICT_STFUNC(Handler, {
-        cFunc(NActors::TEvents::TEvPoison::EventType, TTaskRunnerActor::PassAway);
-        hFunc(TEvTaskRunnerCreate, OnDqTask);
-        hFunc(TEvContinueRun, OnContinueRun);
-        hFunc(TEvPop, OnChannelPop);
-        hFunc(TEvPush, OnChannelPush);
-        hFunc(TEvSinkPop, OnSinkPop);
-        hFunc(TEvSinkPopFinished, OnSinkPopFinished);
-    })
+    STFUNC(Handler) {
+        switch (ev->GetTypeRewrite()) {
+            cFunc(NActors::TEvents::TEvPoison::EventType, TTaskRunnerActor::PassAway);
+            hFunc(TEvTaskRunnerCreate, OnDqTask);
+            hFunc(TEvContinueRun, OnContinueRun);
+            hFunc(TEvPop, OnChannelPop);
+            hFunc(TEvPush, OnChannelPush);
+            hFunc(TEvSinkPop, OnSinkPop);
+            hFunc(TEvSinkPopFinished, OnSinkPopFinished);
+            default: {
+                auto message = TStringBuilder() << "Unexpected event: " << ev->GetTypeRewrite() << " (" << ev->GetTypeName() << ")" << " stageId: " << StageId;
+                auto issue = TIssue(message).SetCode(TIssuesIds::DQ_GATEWAY_NEED_FALLBACK_ERROR, TSeverityIds::S_ERROR);
+                auto reply = MakeHolder<NDq::TEvDq::TEvAbortExecution>(NYql::NDqProto::StatusIds::INTERNAL_ERROR, TVector<TIssue>{issue});
+                Send(ParentId, reply.Release());
+            }
+        }
+    }
 
 private:
     static std::pair<NYql::NDqProto::StatusIds::StatusCode, TString> ParseStderr(const TString& input, TIntrusivePtr<TDqConfiguration> settings) {