YQL-17542 remove function with confusing name CreateKqpTaskRunner (yd…

…b-platform#1183)
dcherednik · Jan 22, 2024 · 34c493d · 34c493d
1 parent 2a760a1
commit 34c493d
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 12 deletions.
diff --git a/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp b/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp
@@ -219,7 +219,7 @@ void TKqpScanComputeActor::DoBootstrap() {
         };
     }
 
-    auto taskRunner = CreateKqpTaskRunner(execCtx, settings, logger);
+    auto taskRunner = MakeDqTaskRunner(execCtx, settings, logger);
     TBase::SetTaskRunner(taskRunner);
 
     auto wakeup = [this] { ContinueExecute(); };

diff --git a/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp b/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp
@@ -218,7 +218,7 @@ class TKqpLiteralExecuter {
                 << message);
         };
 
-        auto taskRunner = CreateKqpTaskRunner(context, settings, log);
+        auto taskRunner = MakeDqTaskRunner(context, settings, log);
         TaskRunners.emplace_back(taskRunner);
 
         auto taskSettings = NDq::TDqTaskSettings(&protoTask);

diff --git a/ydb/core/kqp/runtime/kqp_tasks_runner.cpp b/ydb/core/kqp/runtime/kqp_tasks_runner.cpp
@@ -68,12 +68,6 @@ IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NDqProto::TTaskOutput& outp
     }
 }
 
-TIntrusivePtr<IDqTaskRunner> CreateKqpTaskRunner(const TDqTaskRunnerContext& execCtx,
-    const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc)
-{
-    return MakeDqTaskRunner(execCtx, settings, logFunc);
-}
-
 
 TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrField<NDqProto::TDqTask>&& tasks,
     const TDqTaskRunnerContext& execCtx, const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc)
@@ -92,7 +86,7 @@ TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrField<NDqProto::TD
     try {
         for (auto&& task : tasks) {
             ui64 taskId = task.GetId();
-            auto runner = CreateKqpTaskRunner(execCtx, settings, logFunc);
+            auto runner = MakeDqTaskRunner(execCtx, settings, logFunc);
             if (auto* stats = runner->GetStats()) {
                 Stats.emplace(taskId, stats);
             }

diff --git a/ydb/core/kqp/runtime/kqp_tasks_runner.h b/ydb/core/kqp/runtime/kqp_tasks_runner.h
@@ -12,9 +12,6 @@ NYql::NDq::IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NYql::NDqProto::
     const NKikimr::NMiniKQL::THolderFactory& holderFactory,
     TVector<NYql::NDq::IDqOutput::TPtr>&& outputs);
 
-TIntrusivePtr<NYql::NDq::IDqTaskRunner> CreateKqpTaskRunner(const NYql::NDq::TDqTaskRunnerContext& execCtx,
-    const NYql::NDq::TDqTaskRunnerSettings& settings, const NYql::NDq::TLogFunc& logFunc);
-
 
 class TKqpTasksRunner : public TSimpleRefCount<TKqpTasksRunner>, private TNonCopyable {
 public: