Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we discussed in
#301
about image crop - i enabled the UI to work with ALL image dimensions by wrapping images into a container what is set to a specific aspect ratio, that masks the image nicely into the desired format .
so we can bring images to any desired aspect ratio like this
as the native css support for
aspect-ratio
is still not the best ( missing edge/IE ) i decided to go with a tailwind pluginhttps://github.com/tailwindlabs/tailwindcss-aspect-ratio
that works niceley - via the old "padding-bottom-trick"
you need to rerun
yarn install
before you can see it working.if you want to try out how this truly looks with other dimension images you can easy replace the image source of a card or detail page with a rectangle image via inspector of your browser
src="http://placekitten.com/1000/1000"
or just create a new grant :)