Fix TypeScript issue when using moduleResolution: node16
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notation when using moduleResolution node16/nodenext due to internal twJoin type (ClassNameValue)
|
When using this package the |
|
Hey @LiamMartens! 👋 Exporting the type makes sense to me, even thought about this recently. Could you explain the problem you're trying to solve? I'm just not sure if I understand it correctly. What is the type inference error that happens because of the missing export? I just switched to |
|
@dcastil I get the issue with the
I created a repo : https://github.com/LiamMartens/tailwind-merge-node16-module |
|
Thanks for the reproduction repo! 🙏 Wow, this is a weird error. |
dcastil
changed the title
moduleResolution: node16
|
This was addressed in release v1.13.2. |
sebald
referenced
this pull request
in sebald/pattern-analyzer
Jun 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tailwind-merge](https://togithub.com/dcastil/tailwind-merge) | [`1.13.1` -> `1.13.2`](https://renovatebot.com/diffs/npm/tailwind-merge/1.13.1/1.13.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dcastil/tailwind-merge</summary> ### [`v1.13.2`](https://togithub.com/dcastil/tailwind-merge/releases/tag/v1.13.2) [Compare Source](https://togithub.com/dcastil/tailwind-merge/compare/v1.13.1...v1.13.2) ##### Bug Fixes - Fix grammar and typos in docs by [@​jmmarco](https://togithub.com/jmmarco) in [https://github.com/dcastil/tailwind-merge/pull/249](https://togithub.com/dcastil/tailwind-merge/pull/249) - Fix TypeScript issue when using `moduleResolution: node16` by [@​LiamMartens](https://togithub.com/LiamMartens) in [https://github.com/dcastil/tailwind-merge/pull/245](https://togithub.com/dcastil/tailwind-merge/pull/245) ##### Other - Add tailwind-merge-php to similar packages in docs by [@​JamesHemery](https://togithub.com/JamesHemery) in [https://github.com/dcastil/tailwind-merge/pull/246](https://togithub.com/dcastil/tailwind-merge/pull/246) **Full Changelog**: dcastil/tailwind-merge@v1.13.1...v1.13.2 Thanks to [@​bluetch](https://togithub.com/bluetch) for sponsoring tailwind-merge! ❤️ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sebald/pattern-analyzer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…notation when using moduleResolution node16/nodenext due to internal twJoin type (ClassNameValue)