Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the jsonc documentation for the ehic #115

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

ruediger-stickler
Copy link
Contributor

No description provided.

"type": "object",
"properties": {
"sex": {
"$ref": "#/$defs/sex_type"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to get rid of $ref": "#/$defs/sex_type on line 84?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, will this change only apply to ehic? PDA1 has other_elements as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review, you are right, the sex_type can be removed. regarding the pda1: not only is "other_elements" unnecessary, but the whole person-block. the personal information is not part of the credential, it is part of the upload API. in the ehic it is only included because it can be issued for another person but the holder (e.g. the child). i removed the whole person-block from the pda1.

@ruediger-stickler
Copy link
Contributor Author

i also added the PlantUML source files and the updated diagrams. its ready to be merged now.

@masv3971 masv3971 merged commit 356d8bf into dc4eu:main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants