Generate valid clip path id #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, if you created a dc chart using a complex selector
like dc.barChart('#area .bar'), the resulting clip path id wa invalid:
'area .bar-clip'. This patch replaces spaces, periods, and hash marks
in the id with hyphens to generate a valid clip path id.
gordonwoodhull
added a commit
that referenced
this pull request
Nov 30, 2014
Conflicts: src/coordinate-grid-mixin.js
gordonwoodhull
added a commit
that referenced
this pull request
Nov 30, 2014
@jcamins, adding a simple test for your PR on clip path id to make sure it stays fixed and to show the intended behavior please check and suggest improvements, if any. Thanks!
|
Thanks @jcamins! |
|
Any bug fix releases planned for 1.6.0/1.7.0? Just hit this (and thankfully found the fix), but hoping not to need to maintain a branch here with fixes. |
|
No I don't plan any bug fix releases on the old versions. There are way too many bugs and it's all I can keep up with to work on 2.0. I suggest either upgrading to 2.0 when it's finally released in about a month, or forking 1.6/1.7 (only difference being module support) and applying this fix (which should be easy). At least you won't have to worry about keeping it in sync! |
|
No problem. Good to know the release timeframe for 2.0, already been Decided to work around this for now with some changes to CSS selectors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, if you created a dc chart using a complex selector
like dc.barChart('#area .bar'), the resulting clip path id was invalid:
'area .bar-clip'. This patch replaces spaces, periods, and hash marks
in the id with hyphens to generate a valid clip path id.