Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul zoomable behavior #402

Merged
merged 7 commits into from
Nov 15, 2013
Merged

Overhaul zoomable behavior #402

merged 7 commits into from
Nov 15, 2013

Conversation

jrideout
Copy link
Contributor

@jrideout jrideout commented Nov 6, 2013

Fixes #253

See the spec

Note, this depends on #399

@jrideout
Copy link
Contributor Author

jrideout commented Nov 6, 2013

Note: this is not ready yet. Adding the PR to track progress

@jrideout jrideout mentioned this pull request Nov 6, 2013
@matthull
Copy link
Contributor

matthull commented Nov 7, 2013

@jrideout I'll be a few more days on this one; limited time at the moment, and want to add a pretty comprehensive test suite for coordinate chart as a safety net since the zoom changes are so impacting. When I'm done I'll rebase against master and account for #403 as well if that isn't merged yet.

@matthull
Copy link
Contributor

@jrideout this is about ready to go and rebased last night - however since there are lots of changes to coordinate-grid-chart in other pull requests, I'll wait until this weekend when things are quieter to do final rebase. Should be ready for review next Monday.

@jrideout
Copy link
Contributor Author

@matthull yeah - the pivotal folks have been prolific. This PR touches enough of codebase, that I'd like to get it integrated so you don't have to keep tracking master and so that others can build off it. I think we can have a "Merge Freeze" over the weekend to support your efforts.

@NickQiZhu @gordonwoodhull, if you guys agree, let's hold-off on merges until we get this one merged on monday.

@matthull
Copy link
Contributor

If you want me to go ahead and get this one ready to go tomorrow ahead of #415 I can do that too - just let me know. Mainly trying to avoid doing several more rebases on this PR as new stuff comes in, and since #415 is still in progress I didn't know when would be the right time to pull the trigger.

@jrideout
Copy link
Contributor Author

@matthull - go ahead. We can wait on 415. Fixing the existing featureset has higher priority than new features.

Matt Hull and others added 2 commits November 14, 2013 10:12
Conflicts:
	src/coordinate-grid-chart.js
@NickQiZhu
Copy link
Contributor

Sounds good, I only have enough bandwidth recently to answer questions on user group anyway =)

@matthull
Copy link
Contributor

This is ready to go. All the issues I listed in the wiki article originally are fixed. Two issues I added to the article later (box plot/ordinal and line hover issues) are not fixed. After this is merged I can update the article to indicate which issues are fixed, and perhaps open a ticket for the line hover issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants