-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul zoomable behavior #402
Conversation
Note: this is not ready yet. Adding the PR to track progress |
@jrideout this is about ready to go and rebased last night - however since there are lots of changes to coordinate-grid-chart in other pull requests, I'll wait until this weekend when things are quieter to do final rebase. Should be ready for review next Monday. |
@matthull yeah - the pivotal folks have been prolific. This PR touches enough of codebase, that I'd like to get it integrated so you don't have to keep tracking master and so that others can build off it. I think we can have a "Merge Freeze" over the weekend to support your efforts. @NickQiZhu @gordonwoodhull, if you guys agree, let's hold-off on merges until we get this one merged on monday. |
If you want me to go ahead and get this one ready to go tomorrow ahead of #415 I can do that too - just let me know. Mainly trying to avoid doing several more rebases on this PR as new stuff comes in, and since #415 is still in progress I didn't know when would be the right time to pull the trigger. |
@matthull - go ahead. We can wait on 415. Fixing the existing featureset has higher priority than new features. |
Conflicts: src/coordinate-grid-chart.js
Sounds good, I only have enough bandwidth recently to answer questions on user group anyway =) |
This is ready to go. All the issues I listed in the wiki article originally are fixed. Two issues I added to the article later (box plot/ordinal and line hover issues) are not fixed. After this is merged I can update the article to indicate which issues are fixed, and perhaps open a ticket for the line hover issue. |
Fixes #253
See the spec
Note, this depends on #399