Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref #1096, #1097, #1099, #1100: Fix some outstanding issues with HTML JSDoc #1101

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## 2.0.0 beta 26
* Apply pie chart labels before transition, so they are easier to manipulate with the pretransition hook. Added example of showing percentages in pie chart labels. (Workaround for [#703](https://github.com/dc-js/dc.js/issues/703))
* Documentation of chart registry, by Jasmine Hegman ([#676](https://github.com/dc-js/dc.js/issues/676) / [#1082](https://github.com/dc-js/dc.js/pull/1082))
* HTML documentation generation, by Matt Traynham. There are still some kinks to be worked out here, but in principle it should be more robust than the gigantic markdown file we are generating. ([#1086](https://github.com/dc-js/dc.js/pull/1086)
* HTML documentation generation, by Matt Traynham. There are still some kinks to be worked out here, but in principle it should be more robust than the gigantic markdown file we are generating. ([#1086](https://github.com/dc-js/dc.js/pull/1086))
* Document that you need to use a `RangedFilter` when filtering a range, by koefoed ([#1090](https://github.com/dc-js/dc.js/pull/1090))
* Fix links to box plot examples, by Yuval Greenfield ([#1094](https://github.com/dc-js/dc.js/pull/1094))
* [Sparkline example](http://dc-js.github.io/dc.js/examples/sparkline.html) ([#1013](https://github.com/dc-js/dc.js/issues/1013))
Expand Down
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,11 +216,11 @@ module.exports = function (grunt) {
},
jsdoc: {
dist: {
src: 'dc.js',
src: ['<%= conf.src %>/**/*.js', '!<%= conf.src %>/{banner,footer}.js'],
options: {
destination: 'web/docs/html',
template: 'node_modules/ink-docstrap/template',
configure: 'node_modules/ink-docstrap/template/jsdoc.conf.json'
configure: 'jsdoc.conf.json'
}
}
},
Expand Down
28 changes: 28 additions & 0 deletions jsdoc.conf.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"tags": {
"allowUnknownTags": true
},
"plugins": ["plugins/markdown"],
"templates": {
"logoFile": "",
"cleverLinks": false,
"monospaceLinks": false,
"dateFormat": "ddd MMM Do YYYY",
"outputSourceFiles": true,
"outputSourcePath": true,
"systemName": "dc.js",
"footer": "",
"copyright": "dc.js Copyright © 2012-2016 Copyright 2012-2016 Nick Zhu & the dc.js Developers",
"navType": "vertical",
"theme": "cosmo",
"linenums": true,
"collapseSymbols": false,
"inverseNav": true,
"protocol": "html://",
"methodHeadingReturns": false
},
"markdown": {
"parser": "gfm",
"hardwrap": true
}
}
2 changes: 1 addition & 1 deletion src/bar-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Examples:
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* - {@link http://dc-js.github.com/dc.js/crime/index.html Canadian City Crime Stats}
* @namespace barChart
* @class barChart
* @memberof dc
* @mixes dc.stackMixin
* @mixes dc.coordinateGridMixin
Expand Down
2 changes: 1 addition & 1 deletion src/box-plot.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Examples:
* - {@link http://dc-js.github.io/dc.js/examples/box-plot-time.html Box plot time example}
* - {@link http://dc-js.github.io/dc.js/examples/box-plot.html Box plot example}
* @namespace boxPlot
* @class boxPlot
* @memberof dc
* @mixes dc.coordinateGridMixin
* @example
Expand Down
2 changes: 1 addition & 1 deletion src/bubble-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* Examples:
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* - {@link http://dc-js.github.com/dc.js/vc/index.html US Venture Capital Landscape 2011}
* @namespace bubbleChart
* @class bubbleChart
* @memberof dc
* @mixes dc.bubbleMixin
* @mixes dc.coordinateGridMixin
Expand Down
2 changes: 1 addition & 1 deletion src/bubble-overlay.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*
* Examples:
* - {@link http://dc-js.github.com/dc.js/crime/index.html Canadian City Crime Stats}
* @namespace bubbleOverlay
* @class bubbleOverlay
* @memberof dc
* @mixes dc.bubbleMixin
* @mixes dc.baseMixin
Expand Down
2 changes: 1 addition & 1 deletion src/composite-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Composite charts are a special kind of chart that render multiple charts on the same Coordinate
* Grid. You can overlay (compose) different bar/line/area charts in a single composite chart to
* achieve some quite flexible charting effects.
* @namespace compositeChart
* @class compositeChart
* @memberof dc
* @mixes dc.coordinateGridMixin
* @example
Expand Down
2 changes: 1 addition & 1 deletion src/data-count.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* Examples:
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* @namespace dataCount
* @class dataCount
* @memberof dc
* @mixes dc.baseMixin
* @example
Expand Down
2 changes: 1 addition & 1 deletion src/data-grid.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*
* Examples:
* - {@link http://europarl.me/dc.js/web/ep/index.html List of members of the european parliament}
* @namespace dataGrid
* @class dataGrid
* @memberof dc
* @mixes dc.baseMixin
* @param {String|node|d3.selection} parent - Any valid
Expand Down
2 changes: 1 addition & 1 deletion src/data-table.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* - {@link http://dc-js.github.io/dc.js/examples/table-on-aggregated-data.html dataTable on a crossfilter group}
* ({@link https://github.com/dc-js/dc.js/blob/develop/web/examples/table-on-aggregated-data.html source})
* @namespace dataTable
* @class dataTable
* @memberof dc
* @mixes dc.baseMixin
* @param {String|node|d3.selection} parent - Any valid
Expand Down
2 changes: 1 addition & 1 deletion src/geo-choropleth-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* Examples:
* - {@link http://dc-js.github.com/dc.js/vc/index.html US Venture Capital Landscape 2011}
* @namespace geoChoroplethChart
* @class geoChoroplethChart
* @memberof dc
* @mixes dc.colorMixin
* @mixes dc.baseMixin
Expand Down
2 changes: 1 addition & 1 deletion src/heatmap.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* A heat map is matrix that represents the values of two dimensions of data using colors.
* @namespace heatMap
* @class heatMap
* @memberof dc
* @mixes dc.colorMixin
* @mixes dc.marginMixin
Expand Down
2 changes: 1 addition & 1 deletion src/legend.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Examples:
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* - {@link http://dc-js.github.com/dc.js/crime/index.html Canadian City Crime Stats}
* @namespace legend
* @class legend
* @memberof dc
* @example
* chart.legend(dc.legend().x(400).y(10).itemHeight(13).gap(5))
Expand Down
2 changes: 1 addition & 1 deletion src/line-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Examples:
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* - {@link http://dc-js.github.com/dc.js/crime/index.html Canadian City Crime Stats}
* @namespace lineChart
* @class lineChart
* @memberof dc
* @mixes dc.stackMixin
* @mixes dc.coordinateGridMixin
Expand Down
2 changes: 1 addition & 1 deletion src/number-display.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* A display of a single numeric value.
* Unlike other charts, you do not need to set a dimension. Instead a group object must be provided and
* a valueAccessor that returns a single value.
* @namespace numberDisplay
* @class numberDisplay
* @memberof dc
* @mixes dc.baseMixin
* @example
Expand Down
2 changes: 1 addition & 1 deletion src/pie-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*
* Examples:
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* @namespace pieChart
* @class pieChart
* @memberof dc
* @mixes dc.capMixin
* @mixes dc.colorMixin
Expand Down
2 changes: 1 addition & 1 deletion src/row-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*
* Examples:
* - {@link http://dc-js.github.com/dc.js/ Nasdaq 100 Index}
* @namespace rowChart
* @class rowChart
* @memberof dc
* @mixes dc.capMixin
* @mixes dc.marginMixin
Expand Down
2 changes: 1 addition & 1 deletion src/scatter-plot.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Examples:
* - {@link http://dc-js.github.io/dc.js/examples/scatter.html Scatter Chart}
* - {@link http://dc-js.github.io/dc.js/examples/multi-scatter.html Multi-Scatter Chart}
* @namespace scatterPlot
* @class scatterPlot
* @memberof dc
* @mixes dc.coordinateGridMixin
* @example
Expand Down
2 changes: 1 addition & 1 deletion src/series-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* Examples:
* - {@link http://dc-js.github.io/dc.js/examples/series.html Series Chart}
* @namespace seriesChart
* @class seriesChart
* @memberof dc
* @mixes dc.compositeChart
* @example
Expand Down