add optional selector argument to dc.utils.appendOrSelect

for @davisford The final argument is still the tag to append The middle argument is optional, a selector to look for
dc-js · Dec 6, 2014 · f590cdb · f590cdb · davisford · Dec 6, 2014
1 parent 9b2a041
commit f590cdb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/coordinate-grid-mixin.js b/src/coordinate-grid-mixin.js
@@ -961,7 +961,7 @@ dc.coordinateGridMixin = function (_chart) {
         // cannot select <clippath> elements; bug in WebKit, must select by id
         // https://groups.google.com/forum/#!topic/d3-js/6EpAzQ2gU9I
         var id = getClipPathId();
-        var chartBodyClip = dc.utils.appendOrSelect(defs, id).attr('id', id);
+        var chartBodyClip = dc.utils.appendOrSelect(defs, '#' + id, 'clipPath').attr('id', id);
 
         var padding = _clipPadding * 2;
 

diff --git a/src/utils.js b/src/utils.js
@@ -132,10 +132,11 @@ dc.utils.nameToId = function (name) {
     return name.toLowerCase().replace(/[\s]/g, '_').replace(/[\.']/g, '');
 };
 
-dc.utils.appendOrSelect = function (parent, name) {
-    var element = parent.select(name);
+dc.utils.appendOrSelect = function (parent, selector, tag) {
+    tag = tag || selector;
+    var element = parent.select(selector);
     if (element.empty()) {
-        element = parent.append(name);
+        element = parent.append(tag);
     }
     return element;
 };