Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path optimization should work with changes to the graph #81

Open
gordonwoodhull opened this issue May 17, 2018 · 1 comment
Open

path optimization should work with changes to the graph #81

gordonwoodhull opened this issue May 17, 2018 · 1 comment

Comments

@gordonwoodhull
Copy link
Contributor

Right now we assume that the nodes (& edges) of the graph stay constant and we turn on/off the splines in a separate step.

Really path optimization should be a layout feature which works even if the graph is changing at the same time.
@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented May 17, 2018 •
edited
Loading

In particular:

  • draw_spline_paths should consider a path to be "in view" if the nodes are in the current data, not the current canvas
  • d3v4_force_layout should not crash when it's trying to apply path forces and some of the nodes have disappeared
  • when a path is removed, the splines of the remaining paths should update to the new node positions

gordonwoodhull added a commit that referenced this issue May 30, 2018
@gordonwoodhull
drop path if any nodes missing (instead of crashing)
e9f1f5a 
for #81
gordonwoodhull added a commit to gordonwoodhull/enron-threads that referenced this issue May 30, 2018
@gordonwoodhull
no remove-path special case
387b02f 
this part of dc-js/dc.graph.js#81 has been fixed
and this helps enable single-path selection
gordonwoodhull added a commit that referenced this issue Jun 1, 2018
@gordonwoodhull
drop path if any nodes missing (instead of crashing)
99310ce 
for #81
gordonwoodhull added a commit that referenced this issue Jun 1, 2018
@gordonwoodhull
drop path if any nodes missing (instead of crashing)
16dc5f4 
for #81
zhewang pushed a commit to zhewang/dc.graph.js that referenced this issue Jun 8, 2018
@gordonwoodhull @zhewang
drop path if any nodes missing (instead of crashing)
3acc96e 
for dc-js#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gordonwoodhull