Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliases on functions in collections. #198

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

dburgener
Copy link
Owner

No description provided.

@dburgener
Copy link
Owner Author

This is a partial fix for #194. It addresses the case of an @alias on a function inside a collection.

It doesn't address two other issues:

  1. Aliasing the collection itself
  2. The error reporting if a function isn't found claims the collection doesn't exist, when in fact it's the function in the collection that doesn't exist.

Those are obviously important, but in my opinion, the issue here is the most important, and also it's the easiest of the three to fix. The above two probably require collection information to be better propagated through the code. I'd like to merge this fix and then rewrite #194 to refer specifically to collection propagation.

@dburgener dburgener merged commit e65f016 into main Apr 25, 2023
@dburgener dburgener deleted the dburgener/collection-alias branch April 25, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants