-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.19.0 #81
Conversation
Weird error on the
|
I don't get that error when testing local? |
requirements.txt
Outdated
@@ -1,4 +1,4 @@ | |||
dbt-core~=0.18.0 | |||
git+https://github.com/fishtown-analytics/dbt.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikaelene maybe it's because I'm installing this way which should take the latest commit from dev/kiyoshi-kuromiya
because it is the default branch. Maybe this is because you were installing pre-release cut on PyPI? feel free to change this to whatever you like.
@mikaelene I made this PR so now every change that is pushed to the |
I noticed some weird behaviour that the latest version, even installed from git does not include the latest commit. Can't get my mind around why it is happening. I'll try to hardcode the latest commit. |
# Conflicts: # requirements.txt
… for the proper release...
I don't get why it uses the old version. Incorrect syntax near '!'. is what is supposed to be fixed. Maybe we have to wait?!?... Thanks for trying @swanderz ! |
@jtcohen6 sorry to pull in into yet another dbt-msft PR, but any idea why CircleCI isn't pulling the latest commit from |
I think the package are cached by circleCI. Since it is the same version on the new changes it will still take the cached version of the package. |
I think you're onto something. However, I'm trying to read about clearing the cache and my head is spinning... |
I think I have solved it. Pushing in a minute |
AAAHHHHHH! I am getting crazy! :-) |
@swanderz @mikaelene I'm not enough of a Circle pro for this one. Does it work when you run these tests locally? In all likelihood, we'll be coming out with a second RC this week, given the (tiny) changes we've merged since the first one. |
It works locally and it fails in CircleCI on the thing we fixed in the latest commits. But I am fine waiting a couple of days. |
yeah i found an option for circleci python orb's install-packages orb, I'm still going to make a release cut of this so I can keep testing w/ Synapse |
update: somehow
|
It is now on PyPi |
I want to merge this to master but can't male the tests pass locally. Actually I don't see how they can work in CircleCI either. Or why they worked before. From my understanding the data test executes and I get Anyone have a clue why this works in the CircleCI env? |
I have no idea! and I've been banging my head on this for a week now.... I'm starting to learn now via Stack Overflow... |
It actually passes when run with tox. I don't get this tox thing but I'll do the merge. |
should wait until
0.19.0
is actually released, but the CI tests will still be helpful