Delete unused costing code #826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
reviewed
Oct 30, 2023
Comment on lines
+130
to
+131
| join_to_timespine=input_measure.join_to_timespine, | ||
| fill_nulls_with=input_measure.fill_nulls_with, |
There was a problem hiding this comment.
These are new..... I'm guessing from another branch? Let's revert these from this PR before merge.
There was a problem hiding this comment.
dammit I didn't look at my PR after putting it up 😅 redo time
| @@ -673,6 +673,7 @@ def visit_compute_metrics_node(self, node: ComputeMetricsNode) -> SqlDataSet: | |||
| else: | |||
| expr = metric.name | |||
| # Use a column reference to improve query optimization. | |||
| # Update metric expr to use coalesce; when to join to time spine?? | |||
Comment on lines
+466
to
+467
| join_to_timespine: bool = False | ||
| fill_nulls_with: Optional[int] = None |
| -- Metric Time Dimension 'ds' | ||
| -- Pass Only Elements: | ||
| -- ['count_dogs', 'metric_time__day'] | ||
| date_day, |
There was a problem hiding this comment.
This doesn't belong here either, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #SL-1068
Description
Delete costing code that's no longer used. Discussion on this can be found here.