Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to get_measures_for_metrics response #1606

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

DevonFulcher
Copy link
Contributor

This method constructs its response with __ini__ where others use from_pydantic. So, this field has to be added manually so that it MFS can gain access to it.

@cla-bot cla-bot bot added the cla:yes label Jan 16, 2025
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@DevonFulcher DevonFulcher marked this pull request as ready for review January 16, 2025 19:07
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@DevonFulcher DevonFulcher merged commit 18cea80 into main Jan 16, 2025
11 checks passed
@DevonFulcher DevonFulcher deleted the Add_config_to_get_measures_for_metrics_response branch January 16, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants