This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Fix/redshift comp #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clrcrl
suggested changes
Jul 20, 2020
| @@ -14,7 +14,7 @@ with base as ( | |||
| coalesce(page_link,template_page_link) as url, | |||
| coalesce(page_link,template_page_link) as base_url, | |||
| '/' || {{ dbt_utils.get_url_path('coalesce(page_link,template_page_link)') }} as url_path, | |||
| row_number() over (partition by creative_id, page_link order by _FIVETRAN_SYNCED desc) as row_num | |||
| row_number() over (partition by creative_id, page_link order by _fivetran_synced desc) as row_num | |||
There was a problem hiding this comment.
I wonder if this will break Snowflake. I don't think it will 🤞
There was a problem hiding this comment.
Honestly, I just went ahead and switched it back.
Yeah, I'll defer to you @clrcrl on whether or not we will continue supporting them. If so, we should probably go all in soon. Setup integration tests, move logic out of macros, etc. |
clrcrl
approved these changes
Jul 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
first_valuewindow functions in Redshift require an explicit frame clause.