Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: configs + properties #766

Merged
merged 7 commits into from
Sep 20, 2021
Merged

Refactor: configs + properties #766

merged 7 commits into from
Sep 20, 2021

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented Aug 13, 2021 •
edited
Loading

Two attributes, both alike in dignity,
In fair dbt, which we make all green.
From ancient split break to new unity
Where simple code makes complex docs unclean

  • Before: Configs and properties are two totally separate things, and confusingly so.
  • After: There's a config property. Why can't they be friends?

By the by:

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

Checklist

If you added new pages (delete if not applicable):

  • The page has been added to website/sidebars.js
  • The new page has a unique filename

If you removed existing pages (delete if not applicable):

  • The page has been removed from website/sidebars.js
  • An entry has been added to _redirects

@jtcohen6 jtcohen6 changed the title Refactor: configs + properties [WIP] Refactor: configs + properties Aug 13, 2021
@jtcohen6 jtcohen6 mentioned this pull request Aug 13, 2021
Merged
7 tasks
@jtcohen6
Copy link
Collaborator Author

Reminder to self: also use this as an opportunity to document different merge behavior for configs. Namely, all configs are clobbered except:

  • tags: additive
  • meta: merged (clobbered by key)
  • pre-hook, post-hook: additive

@jtcohen6 jtcohen6 mentioned this pull request Sep 13, 2021
Closed
@jtcohen6
Copy link
Collaborator Author

jtcohen6 commented Sep 14, 2021 •
edited
Loading

I think this is ready for a first look from someone who isn't me. I'm going to continue iterating and self-reviewing. I'm hoping to have this live in next when we cut v0.21.0-rc1 end of week.

I ended up deleting less code than I expected, but I did do a lot of reorganization, and actually added new pages for properties that were previously sort of implied, such as columns.

@jtcohen6 jtcohen6 marked this pull request as ready for review September 14, 2021 16:59
@jtcohen6 jtcohen6 requested a review from annafil as a code owner September 14, 2021 16:59
@jtcohen6 jtcohen6 changed the title [WIP] Refactor: configs + properties Refactor: configs + properties Sep 15, 2021
@jtcohen6 jtcohen6 mentioned this pull request Sep 20, 2021
Merged
3 tasks
@jtcohen6
Copy link
Collaborator Author

jtcohen6 commented Sep 20, 2021 •
edited
Loading

I'm going to merge this into next so that it's live at next.docs.getdbt.com in time for the v0.21.0-rc1 announcement in discourse/slack. I'm going to turn around and open a PR from next into current, with specific requests for review ahead of the final release.

@jasnonaz If you get a chance, I'd still love a sense-check of the main point of entry: Configs, properties, what are they? We can talk more in the PR to come.

Screen Shot 2021-09-20 at 8 51 50 PM

Make a wish!

@jtcohen6 jtcohen6 merged this pull request into next Sep 20, 2021
jtcohen6 added a commit that referenced this pull request Sep 20, 2021
@jtcohen6
Refactor: configs + properties (#766)
a30732f 
* Very incomplete start of first draft

* Second big pass

* Initial self review. Sidebar reorg

* Continue self review. Address #616

* Add note to migration guide
jasnonaz
jasnonaz reviewed Sep 20, 2021
View reviewed changes
Copy link
Contributor

@jasnonaz jasnonaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent writeup!!! Great work JC.

jtcohen6 added a commit that referenced this pull request Oct 4, 2021
@jtcohen6 @matt-winkler @sungchun12
[Release] v0.21.0 (#825)
b24c20e 
* new docs for on_schema_change (#747)

* Prerelease: v0.21.0-b1 (#756)

* Edits for on_schema_change

* dbt source freshness

* DBT_ENV_SECRET_ env var

* dbt build first cut

* Redshift profile ra3 property

* Beta callout in migration guide

* Self-review build docs

* Prerelease: v0.21.0-b2 (#767)

* state:modified subselectors, modified.macros

* Add build RPC method

* PR feedback

* add dbt deps logging example (#798)

* [Prerelease] Prep for 0.21.0-rc1 (#802)

* Switch --models to --select

* BQ snapshot config aliases

* Configurable postgres connect timeout

* Add list --output-keys. Add list RPC method

* Adapter unique_field dbt-labs/dbt-core#3796

* PR feedback: -s replaces -m

* Add BQ execution_project

* Add default property for yaml selectors

* Update migration guide. New fields in sources.json

* Test where config macro

* Dispatch for global macros

* Update build details

* Some self review

* Greedy flag/property for test selection

* Resolve #803 while we're here

* Fix broken link typo

* Refactor: configs + properties (#766)

* Very incomplete start of first draft

* Second big pass

* Initial self review. Sidebar reorg

* Continue self review. Address #616

* Add note to migration guide

* [Prerelease] v0.21 post-RC updates (#831)

* Artifact version bumps

* Add v0.20 -> v0.21 to Cloud upgrade FAQ

* PR feedback from jasnonaz <3

* [Release] v0.21.0 (#839)

* Update links, info in migration guides

* Fix v0.21 discourse link

Co-authored-by: matt-winkler <75497565+matt-winkler@users.noreply.github.com>
Co-authored-by: Sung Won Chung <sungwonchung3@gmail.com>
This was referenced Oct 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnonaz jasnonaz jasnonaz left review comments

@annafil annafil Awaiting requested review from annafil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtcohen6 @jasnonaz