Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Github Actions for Github Deprecation #213

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

callum-mcdata
Copy link
Contributor

What is this PR?

This is a:

  • bug fix with no breaking changes

Description & motivation

This PR mimics the work done in dbt-labs/dbt-core#6635

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
  • I have added an entry to CHANGELOG.md

Tenets to keep in mind

  • A metric value should be consistent everywhere that it is referenced
  • We prefer generalized metrics with many dimensions over specific metrics with few dimensions
  • It should be easier to use dbt’s metrics than it is to avoid them
  • Organization and discoverability are as important as precision
  • One-off models built to power metrics are an anti-pattern

@cla-bot cla-bot bot added the cla:yes The CLA has been signed label Jan 18, 2023
@callum-mcdata callum-mcdata merged commit f362dde into main Jan 20, 2023
@callum-mcdata callum-mcdata deleted the updating-ci-for-github-deprecation branch January 20, 2023 21:56
@callum-mcdata callum-mcdata restored the updating-ci-for-github-deprecation branch January 30, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant