Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for excluding last column in unpivot macro #83

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

alexcampana
Copy link

Excluding the last column of a table in the unpivot macro would add an additional union all to the end.

@drewbanin
Copy link
Contributor

drewbanin commented Sep 12, 2018

Thanks @alexcampana - you can ignore the Circle failure -- i think that's unrelated to your PR.

Please also ignore both my original comment, and me closing this PR by accident -- it has been a long day :)

This looks good to me! Let me see if I can fix the circle issues separately. If I can't do that in a timely manner, then I'm cool with just merging this.

@drewbanin drewbanin closed this Sep 12, 2018
@drewbanin drewbanin reopened this Sep 12, 2018
@drewbanin
Copy link
Contributor

drewbanin commented Sep 14, 2018

@alexcampana just got tests passing over here: #82

I'm waiting on a PR. Once that's merged, if you can pull in master, then your tests will pass and we can merge this! I can update you here when it's merged

@drewbanin
Copy link
Contributor

@alexcampana thanks for your patience! I think if you merge master, these tests should now pass!

@alexcampana
Copy link
Author

@drewbanin no problem, looks like the tests are passing now!

@drewbanin drewbanin merged commit 820aadb into dbt-labs:master Oct 9, 2018
@drewbanin
Copy link
Contributor

@alexcampana I just released 0.1.16. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants