Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify that union_relations() uses union all #760

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

owenprough-sift
Copy link
Contributor

resolves #759

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

SQL supports two primary ways to combine query results: union (de-duping row-wise) and union all (no de-duping). The documentation for the union_relations() macro should be clear about which is used here.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@owenprough-sift
Copy link
Contributor Author

Do trivial documentation updates need entries in CHANGELOG.md?

@owenprough-sift owenprough-sift marked this pull request as ready for review January 13, 2023 20:24
@owenprough-sift owenprough-sift changed the title Clarify that union_relations() uses union all doc: clarify that union_relations() uses union all Jan 13, 2023
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you @owenprough-sift 🙏

In general we don't changelog small documentation changes, but it's not a strictly enforced thing either way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: union_relations uses "union all"
2 participants