Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log whole row in accepted range #391

Closed
wants to merge 1 commit into from
Closed

Log whole row in accepted range #391

wants to merge 1 commit into from

Conversation

matthewrj
Copy link
Contributor

@matthewrj matthewrj commented Jul 16, 2021

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

With the new store failures feature in 0.20.0, we want the whole row stored instead of just the column you are interrogating. This gives you the context required to be able to productively debug test failures. This brings the behaviour in line with what expression_is_true does.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. the star() source)
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@jasnonaz jasnonaz changed the base branch from dev/0.7.0 to master August 30, 2021 13:43
@jasnonaz jasnonaz changed the base branch from master to dev/0.7.0 August 30, 2021 13:45
@jasnonaz
Copy link
Contributor

Closing out because this got merged in #413

@jasnonaz jasnonaz closed this Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants