Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add not_null_proportion schema test and related integration tests #375

Closed

Conversation

stumelius
Copy link
Contributor

@stumelius stumelius commented May 21, 2021

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Quite often real-world data sources have columns that should be non-null but for one reason or another there are a couple of NULL values. This PR implements a not_null_proportion test that allows the user to specify the minimum (at_least) tolerated proportion (e.g., 0.95) of non-null values. There's also an optional at_most argument for which I can't think of a use case but added it anyway as it was trivial to implement.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@stumelius stumelius requested a review from clrcrl as a code owner May 21, 2021 09:35
@jasnonaz
Copy link
Contributor

Closing this out as it got merged in #411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants