-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #341
Update README.md #341
Conversation
Reassigning to Jeremy as dispatch macros are his area of knowledge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @haf!
Am I right in seeing this Slack thread as the context for the change here?
I left a few suggestions. It feels like there are two adjacent-yet-different use cases for leveraging dispatch:
- Extending
dbt_utils
macros to new adapters, by reimplementing low-lying functionality - Overriding
dbt_utils
macros on existing adapters, by reimplementing low-lying functionality (and ensuring the custom version is used by otherdbt_utils
macros)
There's a lot of overlap between them in terms of the actual steps required. I'd like to keep the guidance and context as clear as possible; the reader is likely here because they want to do one or the other.
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @haf!
Improving documentation for how to override macros.