Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #341

Merged
merged 5 commits into from
Mar 15, 2021
Merged

Update README.md #341

merged 5 commits into from
Mar 15, 2021

Conversation

haf
Copy link
Contributor

@haf haf commented Mar 3, 2021

Improving documentation for how to override macros.

@haf haf requested a review from clrcrl as a code owner March 3, 2021 12:59
@clrcrl clrcrl requested review from jtcohen6 and removed request for clrcrl March 3, 2021 15:38
@clrcrl
Copy link
Contributor

clrcrl commented Mar 3, 2021

Reassigning to Jeremy as dispatch macros are his area of knowledge :)

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @haf!

Am I right in seeing this Slack thread as the context for the change here?

I left a few suggestions. It feels like there are two adjacent-yet-different use cases for leveraging dispatch:

  1. Extending dbt_utils macros to new adapters, by reimplementing low-lying functionality
  2. Overriding dbt_utils macros on existing adapters, by reimplementing low-lying functionality (and ensuring the custom version is used by other dbt_utils macros)

There's a lot of overlap between them in terms of the actual steps required. I'd like to keep the guidance and context as clear as possible; the reader is likely here because they want to do one or the other.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
haf and others added 4 commits March 10, 2021 19:13
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @haf!

@jtcohen6 jtcohen6 merged commit ceb2849 into dbt-labs:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants