Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unit argument and apply conversion for kms #340

Merged
merged 10 commits into from
Apr 21, 2021
Merged

feat: add unit argument and apply conversion for kms #340

merged 10 commits into from
Apr 21, 2021

Commits on Apr 17, 2021

  1. add unit argument and apply conversion for kms 

    multiply instead of divide and move logic in core macro

rename things a bit

update readme
    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    ac730a0 View commit details
    Browse the repository at this point in the history

  2. add test data and test for haversine 

    too many curly brackets

make params be strings

pass strings

remove round to see if this was the problem

let's try casting

round the output field instead

add commas

cast the macro result directly

rename expected to output

is it a rounding error

swap the units

what is going on...

throw a log to see what we get

remove curlies

try computing in a CTE first'

add comma

I'm sleeping...

fixup! I'm sleeping...

rename in CTE

dont quote?

fix macro and separate unit in two tests

fix yaml indent

fix indentation in schema yaml

alias the field

clean up

fixup! clean up

make the macro log stuff

remove logging in test macro

remove the select star
    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    85c7d8f View commit details
    Browse the repository at this point in the history

  3. remove logging in macro

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    61ac149 View commit details
    Browse the repository at this point in the history

  4. fix typo in readme

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    a711ff8 View commit details
    Browse the repository at this point in the history

  5. add a unioned test case for haversine sin unit

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    d3b435b View commit details
    Browse the repository at this point in the history

  6. add snowflake specific implementation

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    20b3fc4 View commit details
    Browse the repository at this point in the history

  7. make implementation with pow() default

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    9026617 View commit details
    Browse the repository at this point in the history

  8. make a big query adapted macro

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    6ea2ff2 View commit details
    Browse the repository at this point in the history

  9. rename radians converted vars to be more transparent

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    0152392 View commit details
    Browse the repository at this point in the history

  10. implement review feedback

    @bastienboutonnet
    bastienboutonnet committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    0e151dd View commit details
    Browse the repository at this point in the history