Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential values v2 #327

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Sequential values v2 #327

merged 2 commits into from
Apr 5, 2021

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Jan 19, 2021

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • (possibly) a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

This macro builds on work done in #264, to add a general test that a column has sequential values (i.e. an arithmetic series)

It's a little different to the exact functionality of that test, but I think this one is more generally useful

🚨 Note: when getting the tests passing, I noticed that the date_add macro has some strange behavior on BigQuery — we use datetime_add, and cast to a datetime rather than a timestamp (thus losing any timezone info).

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@clrcrl clrcrl marked this pull request as ready for review April 5, 2021 18:26
@clrcrl clrcrl mentioned this pull request Apr 5, 2021
11 tasks
@clrcrl clrcrl merged commit b35f7ed into dev/0.7.0 Apr 5, 2021
@clrcrl clrcrl deleted the sequential-values-v2 branch April 5, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant