Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with contributor list #620

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix bug with contributor list #620

merged 1 commit into from
Feb 1, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 31, 2023

resolves #548, extension of #603

Description

Extensive testing surfaced another bug in all repos where contributors with multiple issues on a single changelog were not generating properly as separate issues. This has not surfaced because generally it's just core group members that have a changelog entry with multiple issues and they never show up in the contributors section.

Checklist

@cla-bot cla-bot bot added the cla:yes label Jan 31, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jan 31, 2023
@emmyoop emmyoop requested a review from McKnight-42 January 31, 2023 17:40
@emmyoop emmyoop merged commit 5d27961 into main Feb 1, 2023
@emmyoop emmyoop deleted the er/ct-1648-fix-contributors branch February 1, 2023 19:47
emmyoop added a commit that referenced this pull request Feb 1, 2023
emmyoop added a commit that referenced this pull request Feb 1, 2023
emmyoop added a commit that referenced this pull request Feb 1, 2023
emmyoop added a commit that referenced this pull request Feb 1, 2023
emmyoop added a commit that referenced this pull request Feb 2, 2023
* remove PR requirement for changie and allow multiple issues per changelog (#603)

* change type to string (#611)

* change type to string

* reduce required length to 1

* fix bug with contributor list (#620)
emmyoop added a commit that referenced this pull request Feb 2, 2023
* remove PR requirement for changie and allow multiple issues per changelog (#603)

* change type to string (#611)

* change type to string

* reduce required length to 1

* fix bug with contributor list (#620)
emmyoop added a commit that referenced this pull request Feb 2, 2023
* remove PR requirement for changie and allow multiple issues per changelog (#603)

* change type to string (#611)

* change type to string

* reduce required length to 1

* fix bug with contributor list (#620)
emmyoop added a commit that referenced this pull request Feb 2, 2023
* remove PR requirement for changie and allow multiple issues per changelog (#603)

* change type to string (#611)

* change type to string

* reduce required length to 1

* fix bug with contributor list (#620)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1648] Remove PR# from changelogs
2 participants