Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert warn_or_error to use specific event #309

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 4, 2022

resolves #308

Description

Convert to use new event

Still need to test locally that warnings are emitted as expected since this event is usually not called directly

Checklist

@cla-bot cla-bot bot added the cla:yes label Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Nov 4, 2022
@emmyoop emmyoop changed the base branch from main to mcknight/ct-1469 November 4, 2022 14:41
@dave-connors-3
Copy link
Contributor

just bumped into this issue locally! is this slated to be merged today?

@emmyoop emmyoop changed the base branch from mcknight/ct-1469 to main November 4, 2022 15:31
@emmyoop
Copy link
Member Author

emmyoop commented Nov 4, 2022

@dave-connors-3 that's the plan. We just need to verify the log message gets generated as expected then we should be able to merge it in.

@emmyoop emmyoop force-pushed the er/ct-1473-warn-error branch from 2723c08 to 6b0e6aa Compare November 4, 2022 15:35
@emmyoop emmyoop requested a review from McKnight-42 November 4, 2022 15:39
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran locally after digging into testing and was able to prove proper output

@emmyoop
Copy link
Member Author

emmyoop commented Nov 4, 2022

@leahwicz - can you override these failing tests to merge this in? This is blocking the fix that will resolve the test errors: #307

This change is only for 1.4 but the other PR will need to be backported - that's why they are separate.

@emmyoop
Copy link
Member Author

emmyoop commented Nov 4, 2022

Also wanted to note this fix is a bit of a stopgap until dbt-labs/dbt-core#6165 can be done. Notes there are this as well.

@leahwicz leahwicz merged commit 6a1647e into main Nov 4, 2022
@leahwicz leahwicz deleted the er/ct-1473-warn-error branch November 4, 2022 21:18
@leahwicz
Copy link
Contributor

leahwicz commented Nov 4, 2022

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1473] Convert warn_or_error to new format
4 participants