-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert warn_or_error to use specific event #309
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
just bumped into this issue locally! is this slated to be merged today? |
@dave-connors-3 that's the plan. We just need to verify the log message gets generated as expected then we should be able to merge it in. |
2723c08
to
6b0e6aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran locally after digging into testing and was able to prove proper output
Also wanted to note this fix is a bit of a stopgap until dbt-labs/dbt-core#6165 can be done. Notes there are this as well. |
Done! |
resolves #308
Description
Convert to use new event
Still need to test locally that warnings are emitted as expected since this event is usually not called directly
Checklist
changie new
to create a changelog entry