[Backport 1.5.latest] Fix for #419: dbt-redshift 1.5 does not work with non-standard redshift hostnames #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ft hostnames (#420) * Fix for region parsing in host name.WIP * Edge cases and cleanup * Minor nits * clean up aws regions invocation * Log message and doc nits * Changie entry * Skip validation if aws regions are not determined * move the regions var earlier to effectively cache (cherry picked from commit b644963)
nssalian
requested review from
dbeatty10,
VersusFacit and
leahwicz
and removed request for
colin-rogers-dbt
VersusFacit
approved these changes
Apr 29, 2023
|
@nssalian is this a regression or just a bug fix we want to get in? How risky would you say this change is since it would go straight to production runs |
This is a fix for the regression reported #419. I reviewed it with the Redshift team @sathiish-kumar was helpful to review here and we don't see a risk for runs. The ConnectionManager should at most be called once so the region calculation should be once. And if it fails, there's a fallback to pass through so things aren't blocked. |
leahwicz
approved these changes
May 3, 2023
There was a problem hiding this comment.
I'm approving but @nathaniel-may for visibility in case you disagree
nathaniel-may
approved these changes
May 3, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b644963 from #420.