Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model-Level Constraints #395

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Conversation

peterallenwebb
Copy link
Contributor

resolves #343

Description

Adds Redshift support for model-level constraints. Core issue: dbt-labs/dbt-core#6754

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner April 6, 2023 14:38
@peterallenwebb peterallenwebb requested a review from nssalian April 6, 2023 14:38
@cla-bot cla-bot bot added the cla:yes label Apr 6, 2023
@peterallenwebb peterallenwebb changed the title CT-2222: Redshift adapter support for model-level constrints Model-Level Constrints Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@peterallenwebb peterallenwebb changed the title Model-Level Constrints Model-Level Constraints Apr 6, 2023
VersusFacit
VersusFacit previously approved these changes Apr 11, 2023
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice looking PR. I'll approve this for real once tests are passing

@VersusFacit VersusFacit self-requested a review April 11, 2023 06:28
@VersusFacit VersusFacit dismissed their stale review April 11, 2023 06:29

Tests aren't passing yet

@peterallenwebb peterallenwebb merged commit d348945 into main Apr 11, 2023
@peterallenwebb peterallenwebb deleted the paw/CT-2222-model-level-constraints branch April 11, 2023 17:59
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
* CT-2222: Redshift adapter support for model-level constrints

* CT-2222: Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2222] [Redshift] Add model-level constraints to get_columns_spec_ddl
3 participants