Feature: Block-level copying of Jinja content between split projects #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyager
added
bug
dave-connors-3
approved these changes
Jan 2, 2024
| if node is None: | ||
| continue | ||
|
|
||
| if hasattr(node, "raw_code"): |
There was a problem hiding this comment.
forgetting which nodes have raw_code -- does this indicate we'd be searching the content of a model for docs blocks? are we looking for docs in the definition of YML only resources in this step?
There was a problem hiding this comment.
I think you've figured this out already, but yes. This checks raw_code, and the next check on line 482 checks wihtin the YAML file, too.
| if hasattr(node, "raw_code"): | ||
| docs.update(find_doc_reference(node.raw_code)) | ||
|
|
||
| if hasattr(node, "patch_path"): |
There was a problem hiding this comment.
ah i think this answers my above question
| @@ -53,7 +58,8 @@ models: | |||
| to: ref('stg_customers') | |||
| field: customer_id | |||
| - name: location_id | |||
| description: The foreign key relating to the location the order was placed | |||
| description: | |||
There was a problem hiding this comment.
a note for future us -- we gotta see if ruamel can stop editing newlines 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
There are two PRs related to copying Jinja blocks to split dbt projects. One has to do with block-level copying of macros, to prevent multiple macros in the same file being copyied to a split project, and the other has to do with doc blocks not being copied over due to an absence of references. This PR resolves both issues.
JinjaBlocksat a character position level. This is accomplished by usingdocsandmacrosproperties of aManifest, coupled with some clever RegEx, to find where things start and end. Note that the RegEx may be brittle, so 👀appendOperation to our file editors, allowing us to append-only edit files (like if we're moving a Jinja block from one place to another!).DbtSubProjectso we know which doc blocks are being referenced in which code and patch files. This allows us to track which Doc blocks need to be copied, too!Resolves: #142
Resolves: #158