pass args as string #185
Merged
pass args as string #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyager
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
@dave-connors-3 I have one small suggestion to remove a debugger line, but otherwise this looks good!
| @@ -320,12 +320,17 @@ def select_resources( | |||
| ) -> Set[str]: | |||
| """Select dbt resources using NodeSelection syntax""" | |||
| args = [] | |||
| # import pdb; pdb.set_trace() | |||
There was a problem hiding this comment.
Suggested change
| # import pdb; pdb.set_trace() |
2 tasks
|
Resolves #186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes dbt-meshify compatible with the latest dbt core release by passing any multiselect args to
dbt lsas a single string separated by spaces, which is accepted by the parser in dbt core.My initial implementation was to convert the tuple that is returned from our meshify command to a list, but that raised the same error as before -- if appears the type check we were discussing in our sync is not relevant for the
--selectflag, and is used for other flags.I tested on 1.6.3+, and these changes appear to work across versions