handle missing packages exception #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbt_meshify/dbt.py
Outdated
Comment on lines
31
to
36
| try: | ||
| return self.invoke(directory, ["--quiet", "parse"]) | ||
| except UninstalledPackagesFoundError: | ||
| logger.debug("Project missing packages, installing...") | ||
| self.invoke(directory, ["deps"]) | ||
| return self.invoke(directory, ["--quiet", "parse"]) |
There was a problem hiding this comment.
This is very clever! 🤔 Does this exception ever get raised for other Dbt methods? If so, it may make sense to wrap/decorate invoke() directly to handle this exception for all dbt calls. Thoughts, @dave-connors-3?
There was a problem hiding this comment.
ah great point! I think it's around for any submitted command when packages aren't installed, but I put it in parse since it's always the first method we call. I can add it up a level to invoke to be safer!
nicholasyager
approved these changes
Sep 19, 2023
Comment on lines
+23
to
+28
| if not result.success and result.exception: | ||
| if isinstance(result.exception, UninstalledPackagesFoundError): | ||
| logger.debug("Project missing packages, running dbt deps...") | ||
| self.dbt_runner.invoke(["deps"]) | ||
| result = self.dbt_runner.invoke(runner_args if runner_args else []) | ||
|
|
There was a problem hiding this comment.
I really like that we'll be covered now regardless of our command. Fantastic enhancement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
This catches a
UninstalledPackagesFoundErrorwhen parsing a dbt project, and runs deps automatically before parsing!yabba dabba doo!