clean subgraph before identifying boundary in split operation #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eak the rest of the tests
nicholasyager
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
@dave-connors-3 This approach is both necessary and sufficient for removing tests from the boundary detection used in splitting. The test is a little lazy, but it's also effective, so I'm cool with it 👍🏻 ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
This PR adds a line to clean the subproject's graph of test nodes before identifying the boundary nodes.
This operation is called during the creation of a group, but not splitting a project, resulting in divergent behavior.
to test this, I added a tested leaf node to the project, and added a test case that splits that node out and makes sure it's public. I did a lazy version of checking the yml -- @nicholasyager should that be a named list?